Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 306733002: Make ContextDirectoryManager responsible for scanning directory contents. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make ContextDirectoryManager responsible for scanning directory contents. It will be responsible for updating the context when the contents of the directory have changed, so it makes sense to have it do the initial scan as well. R=danrubel@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36785

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +8 lines, -34 lines 2 comments Download
M pkg/analysis_server/lib/src/context_directory_manager.dart View 2 chunks +37 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/context_directory_manager_test.dart View 2 chunks +57 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
6 years, 6 months ago (2014-05-28 21:20:55 UTC) #1
scheglov
LGTM
6 years, 6 months ago (2014-05-28 21:45:14 UTC) #2
danrubel
lgtm https://codereview.chromium.org/306733002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/306733002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode443 pkg/analysis_server/lib/src/analysis_server.dart:443: class PubFolder { This now represents an analysis ...
6 years, 6 months ago (2014-05-29 12:07:19 UTC) #3
Paul Berry
https://codereview.chromium.org/306733002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/306733002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode443 pkg/analysis_server/lib/src/analysis_server.dart:443: class PubFolder { On 2014/05/29 12:07:19, danrubel wrote: > ...
6 years, 6 months ago (2014-05-29 15:22:16 UTC) #4
Paul Berry
6 years, 6 months ago (2014-05-29 15:26:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r36785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698