Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 306693002: Remove support for the special "assets" directory. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for the special "assets" directory. BUG=https://code.google.com/p/dart/issues/detail?id=16647 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=36769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -376 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback.dart View 2 chunks +3 lines, -21 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/barback_server.dart View 3 chunks +2 lines, -22 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/build.dart View 4 chunks +5 lines, -14 lines 0 comments Download
M sdk/lib/_internal/pub/test/barback/directory_args_test.dart View 2 chunks +3 lines, -14 lines 0 comments Download
M sdk/lib/_internal/pub/test/build/handles_long_paths_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_in_lib_test.dart View 1 chunk +0 lines, -78 lines 0 comments Download
M sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/invalid_urls_test.dart View 1 chunk +4 lines, -18 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/serve_from_app_asset_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/serve_from_dependency_asset_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_test.dart View 2 chunks +0 lines, -25 lines 0 comments Download
D sdk/lib/_internal/pub/test/transformer/runs_a_transform_on_a_dependency_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/runs_a_transformer_on_a_dependency_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
6 years, 6 months ago (2014-05-28 18:04:02 UTC) #1
nweiz
lgtm
6 years, 6 months ago (2014-05-28 20:41:07 UTC) #2
Bob Nystrom
6 years, 6 months ago (2014-05-28 20:54:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698