Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 306643002: Pass isolates explicitly. (Closed)

Created:
6 years, 7 months ago by srdjan
Modified:
6 years, 6 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -110 lines) Patch
M runtime/vm/code_descriptors_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 63 chunks +117 lines, -98 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 4 chunks +9 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 6 months ago (2014-05-28 14:07:44 UTC) #1
Cutch
lgtm
6 years, 6 months ago (2014-05-28 14:16:46 UTC) #2
srdjan
6 years, 6 months ago (2014-05-28 14:25:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698