Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 306523002: Tweak isolate/spawn_uri_missing*test.dart (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweak isolate/spawn_uri_missing*test.dart R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=36676

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M dart/tests/isolate/spawn_uri_missing_from_isolate_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M dart/tests/isolate/spawn_uri_missing_test.dart View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
ahe
6 years, 7 months ago (2014-05-27 11:10:59 UTC) #1
Lasse Reichstein Nielsen
Could be simpler, but LGTM. https://codereview.chromium.org/306523002/diff/1/dart/tests/isolate/spawn_uri_missing_test.dart File dart/tests/isolate/spawn_uri_missing_test.dart (right): https://codereview.chromium.org/306523002/diff/1/dart/tests/isolate/spawn_uri_missing_test.dart#newcode25 dart/tests/isolate/spawn_uri_missing_test.dart:25: }); This seem overly ...
6 years, 7 months ago (2014-05-27 12:09:15 UTC) #2
ahe
Thank you, Lasse! https://codereview.chromium.org/306523002/diff/1/dart/tests/isolate/spawn_uri_missing_test.dart File dart/tests/isolate/spawn_uri_missing_test.dart (right): https://codereview.chromium.org/306523002/diff/1/dart/tests/isolate/spawn_uri_missing_test.dart#newcode25 dart/tests/isolate/spawn_uri_missing_test.dart:25: }); On 2014/05/27 12:09:15, Lasse Reichstein ...
6 years, 7 months ago (2014-05-27 13:31:27 UTC) #3
ahe
6 years, 7 months ago (2014-05-27 13:32:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698