Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 305763002: Create a new class for managing the set of analysis roots. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create a new class for managing the set of analysis roots. This will allow the functionality of mapping analysis roots to context folders to be tested in isolation. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36768

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +25 lines, -41 lines 2 comments Download
A pkg/analysis_server/lib/src/context_directory_manager.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/context_directory_manager_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
6 years, 6 months ago (2014-05-28 20:23:46 UTC) #1
scheglov
https://codereview.chromium.org/305763002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/305763002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode308 pkg/analysis_server/lib/src/analysis_server.dart:308: contextDirectoryManager.setRoots(includedPaths, excludedPaths); Does it still work for the simplest ...
6 years, 6 months ago (2014-05-28 20:28:40 UTC) #2
Paul Berry
https://codereview.chromium.org/305763002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/305763002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode308 pkg/analysis_server/lib/src/analysis_server.dart:308: contextDirectoryManager.setRoots(includedPaths, excludedPaths); On 2014/05/28 20:28:41, scheglov wrote: > Does ...
6 years, 6 months ago (2014-05-28 20:33:32 UTC) #3
scheglov
LGTM
6 years, 6 months ago (2014-05-28 20:36:37 UTC) #4
Paul Berry
6 years, 6 months ago (2014-05-28 20:50:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r36768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698