Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 305653002: Cache the current token in some functions in the parser (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 6 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Cache the current token in some functions in the parser Avoid some calls to CurrentToken(). Compiling all of dart2js, this saves about 10% of calls to CurrentToken(). There is no measurable performance difference (using wall-clock time). R=iposva@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36763

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M runtime/vm/parser.cc View 10 chunks +48 lines, -43 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
hausner
Not sure whether Srdjan is able to look at this, so adding Ivan as well. ...
6 years, 7 months ago (2014-05-27 23:50:50 UTC) #1
srdjan
LGTM. https://codereview.chromium.org/305653002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/305653002/diff/1/runtime/vm/parser.cc#newcode10737 runtime/vm/parser.cc:10737: token == Token::kLBRACE) { Add parentheses here and ...
6 years, 7 months ago (2014-05-28 02:25:13 UTC) #2
Ivan Posva
LGTM -ip
6 years, 7 months ago (2014-05-28 06:38:30 UTC) #3
hausner
6 years, 6 months ago (2014-05-28 20:21:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698