Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 305633003: Patch long names in polymer/e2e_test/... (updates test_suite.dart) (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch long names in polymer/e2e_test/... (updates test_suite.dart) R=jmesserly@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36755

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M pkg/pkg.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-05-27 23:02:04 UTC) #1
ricow1
lgtm, thank you (although I hate the fact that we need to do this in ...
6 years, 6 months ago (2014-05-28 06:07:49 UTC) #2
Jennifer Messerly
lgtm
6 years, 6 months ago (2014-05-28 18:08:38 UTC) #3
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-05-28 18:14:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698