Issue 305603004: Observatory now uses websockets to communicate with the vm.

Issue 305603004: Observatory now uses websockets to communicate with the vm. (Closed)

Created:
6 years, 6 months ago by turnidge

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org, Chris Bracken

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Observatory now uses websockets to communicate with the vm. - Added WebSocketVM class. - Changed the vmservice websocket request format from: path: ['this', 'is', 'the', 'old] to: request: 'this/is/the/new' - Updated tests. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36894

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : gen js #

Patch Set 4 : gen js #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1499 lines, -1299 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	225 chunks	+706 lines, -644 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	225 chunks	+706 lines, -644 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/service_html.dart	View		3 chunks	+80 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/application.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/server.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/vmservice/test_helper.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/vmservice/websocket_client_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm https://codereview.chromium.org/305603004/diff/20001/runtime/bin/vmservice/client/lib/service_html.dart File runtime/bin/vmservice/client/lib/service_html.dart (right): https://codereview.chromium.org/305603004/diff/20001/runtime/bin/vmservice/client/lib/service_html.dart#newcode109 runtime/bin/vmservice/client/lib/service_html.dart:109: ' VM with the following flags:\n --enable-vm-service' We ...

6 years, 6 months ago (2014-05-28 19:31:48 UTC) #2

turnidge

6 years, 6 months ago (2014-06-02 19:56:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r36894 (presubmit successful).

Expand Messages | Collapse Messages