Issue 305473002: Add --observe flag alias

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305473002: Add --observe flag alias (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 7 months ago

Reviewers:
bakster, Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --observe flag alias BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=36648

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -18 lines)			Patch
	M	runtime/bin/main.cc	View	1 2	15 chunks	+45 lines, -18 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #3 manually as r36648 (presubmit successful).

6 years, 7 months ago (2014-05-27 07:26:11 UTC) #3

bakster

6 years, 7 months ago (2014-05-27 07:34:27 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/305473002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/305473002/diff/40001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:296: Log::PrintErr("unrecognized --enable-vm-service option
syntax. "
If this function is called from ProcessObserveOption and it ExtractPortAndIP
fails the error message is misleading.

https://codereview.chromium.org/305473002/diff/40001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:307: ASSERT(option_value != NULL);
The assert is not needed since ProcessEnableVmServiceOption has an asset.

Expand Messages | Collapse Messages