Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 305453003: Add dart2js batch mode support (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dart2js batch mode support This removes an old map from runtimes to executables that is no longer needed and instead assumes a ProcessCommand that has an executable. The added benefit of this is that it works with --use-sdk (and there are less code to maintain) The flag to enable dart2js batch mode is temporary until we can switch the default. When we can, this can go away and we can reuse the noBatch flag (which defaults to false) R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M tools/testing/dart/test_options.dart View 1 chunk +8 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 4 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-26 10:27:27 UTC) #1
Bill Hesse
lgtm
6 years, 7 months ago (2014-05-26 10:50:59 UTC) #2
ricow1
+kevin When we start defaulting to this dart2dart will also be run in batch mode, ...
6 years, 7 months ago (2014-05-26 10:52:46 UTC) #3
ricow1
6 years, 7 months ago (2014-05-26 11:03:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698