Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 30533004: Report correct error message in case of super invocation (fix issue 8208). (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Report correct error message in case of super invocation (fix issue 8208). R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=29042

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -45 lines) Patch
M runtime/lib/errors_patch.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/lib/invocation_mirror.h View 1 1 chunk +6 lines, -5 lines 0 comments Download
M runtime/lib/invocation_mirror_patch.dart View 1 3 chunks +20 lines, -13 lines 0 comments Download
M runtime/lib/object.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 6 chunks +12 lines, -6 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 8 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 2 months ago (2013-10-22 20:22:32 UTC) #1
hausner
lgtm
7 years, 2 months ago (2013-10-22 22:06:25 UTC) #2
regis
Thanks!
7 years, 2 months ago (2013-10-22 22:11:44 UTC) #3
regis
7 years, 2 months ago (2013-10-22 22:12:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698