Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 304513004: Add 'owner' field to sockets, that point to a potential IO resource using that Socket. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add 'owner' field to sockets, that point to a potential IO resource using that Socket. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36680

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M runtime/bin/socket_patch.dart View 1 7 chunks +14 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.html View 2 chunks +21 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 3 chunks +3 lines, -0 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-27 13:56:21 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-27 14:08:11 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-27 14:10:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698