Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 304323004: Computers and services snapshot. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -108 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/LocalAnalysisServerImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitCompletionSuggestionsComputer.java View 5 chunks +53 lines, -41 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/SearchResultConverter.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/TypeHierarchyComputer.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/TypeHierarchyItemImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 1 chunk +11 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainAnalysisServer.java View 3 chunks +16 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated/service_computers.dart View 28 chunks +194 lines, -26 lines 0 comments Download
M pkg/analysis_server/lib/src/generated/service_interfaces.dart View 7 chunks +281 lines, -33 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/lib/src/generated/completion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-05-29 20:55:26 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-05-29 22:18:11 UTC) #2
scheglov
6 years, 6 months ago (2014-05-29 22:19:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698