Use 'analysis.setSubscriptions' HIGHLIGHTS in Editor.

Use 'analysis.setSubscriptions' HIGHLIGHTS in Editor.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36853

[Brian Wilkerson, 2014-05-30 22:49:13]

LGTM

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteRequestSink.java
(right):

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteRequestSink.java:46:
//    System.out.println(System.currentTimeMillis() + " => " + text);
Was it intentional to leave this in?

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java
(right):

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java:149:
getAnalysisSubscriptionList(AnalysisService.HIGHLIGHTS).remove(file);
Will we ever end up creating a previously non-existent list in order to remove a
file that wasn't in it?

If we remove the last element of the list, do we need to remove the list from
the map?

If either answer is 'yes' then it might be cleaner to have a 'addSubscription'
and 'removeSubscription' pair.

[scheglov, 2014-05-31 01:51:20]

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteRequestSink.java
(right):

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteRequestSink.java:46:
//    System.out.println(System.currentTimeMillis() + " => " + text);
On 2014/05/30 22:49:13, Brian Wilkerson wrote:
> Was it intentional to leave this in?

Yes.
When I debug the server, I uncomment it.

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java
(right):

https://codereview.chromium.org/304273007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java:149:
getAnalysisSubscriptionList(AnalysisService.HIGHLIGHTS).remove(file);
On 2014/05/30 22:49:13, Brian Wilkerson wrote:
> Will we ever end up creating a previously non-existent list in order to remove
a
> file that wasn't in it?
> 
> If we remove the last element of the list, do we need to remove the list from
> the map?
> 
> If either answer is 'yes' then it might be cleaner to have a 'addSubscription'
> and 'removeSubscription' pair.

Good idea.
Done.

[scheglov, 2014-05-31 01:53:36]

Committed patchset #2 manually as r36853 (presubmit successful).