Issue 304203004: Correctly handle case where we have a library outside of a package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304203004: Correctly handle case where we have a library outside of a package. (Closed)

Created:
6 years, 6 months ago by Emily Fortuna

Modified:
6 years, 6 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Correctly handle case where we have a library outside of a package. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=36795

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -16 lines)			Patch
M	pkg/docgen/lib/docgen.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/docgen/lib/src/generator.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/docgen/lib/src/library_helpers.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/docgen/lib/src/models/library.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/docgen/lib/src/package_helpers.dart	View	2 chunks	+46 lines, -4 lines	1 comment	Download

Total messages: 3 (0 generated)

Emily Fortuna

This is reapplying the change of https://codereview.chromium.org//288033010 With the addition of one line in package_helpers.dart ...

6 years, 6 months ago (2014-05-29 16:34:47 UTC) #1

Emily Fortuna

6 years, 6 months ago (2014-05-29 17:50:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36795 (presubmit successful).