Issue 30353003: Removing some deprecated members

Issue 30353003: Removing some deprecated members (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing some deprecated members These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=29022

Patch Set 1 : #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -1272 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		49 chunks	+7 lines, -444 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		118 chunks	+76 lines, -590 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		3 chunks	+0 lines, -66 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		7 chunks	+4 lines, -70 lines	0 comments	Download
M	tests/html/html.status	View	1	7 chunks	+0 lines, -7 lines	0 comments	Download
D	tests/html/notifications_test.dart	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	tools/dom/dom.json	View		20 chunks	+93 lines, -23 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 2	5 chunks	+9 lines, -14 lines	0 comments	Download
M	tools/dom/src/EventStreamProvider.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_EventTarget.darttemplate	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

looks good. just minor stuff. https://codereview.chromium.org/30353003/diff/90001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/30353003/diff/90001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode10477 sdk/lib/html/dart2js/html_dart2js.dart:10477: String getAttribute(String name) native; ...

7 years, 2 months ago (2013-10-21 21:57:47 UTC) #2

blois

https://codereview.chromium.org/30353003/diff/90001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/30353003/diff/90001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode10477 sdk/lib/html/dart2js/html_dart2js.dart:10477: String getAttribute(String name) native; On 2013/10/21 21:57:48, Emily Fortuna ...

7 years, 2 months ago (2013-10-21 23:23:34 UTC) #3

blois

7 years, 2 months ago (2013-10-22 18:42:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r29022 (presubmit successful).

Expand Messages | Collapse Messages