Issue 303503007: Allow physical folder resources to be watched for changes to their contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303503007: Allow physical folder resources to be watched for changes to their contents. (Closed)

Created:
6 years, 7 months ago by Paul Berry

Modified:
6 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow physical folder resources to be watched for changes to their contents. This functionality is just a thin wrapper over the existing Watcher package. A future CL will add similar functionality to in-memory folder resources. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36714

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -0 lines)			Patch
M	pkg/analysis_server/lib/src/resource.dart	View	4 chunks	+17 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/test/resource_test.dart	View	3 chunks	+88 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/303503007/diff/1/pkg/analysis_server/test/resource_test.dart File pkg/analysis_server/test/resource_test.dart (right): https://codereview.chromium.org/303503007/diff/1/pkg/analysis_server/test/resource_test.dart#newcode258 pkg/analysis_server/test/resource_test.dart:258: // On windows, watching the filesystem is accomplished ...

6 years, 7 months ago (2014-05-27 22:15:14 UTC) #2

Paul Berry

Committed patchset #1 manually as r36714 (presubmit successful).

6 years, 7 months ago (2014-05-27 22:36:25 UTC) #3

Paul Berry

6 years, 7 months ago (2014-05-27 22:37:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/303503007/diff/1/pkg/analysis_server/test/res...
File pkg/analysis_server/test/resource_test.dart (right):

https://codereview.chromium.org/303503007/diff/1/pkg/analysis_server/test/res...
pkg/analysis_server/test/resource_test.dart:258: // On windows, watching the
filesystem is accomplished by polling once
On 2014/05/27 22:15:14, scheglov wrote:
> "On Windows"

Done.

Expand Messages | Collapse Messages