Issue 303443010: Prepares for arm64 cross-build.

Issue 303443010: Prepares for arm64 cross-build. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis, Ivan Posva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Prepares for arm64 cross-build. With this change, the cross-build succeeds with the Linaro arm64 toolchain. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36698

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -11 lines)			Patch
M	runtime/bin/net/nss.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/globals.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/cpu_arm64.cc	View	1	1 chunk	+21 lines, -4 lines	0 comments	Download
M	runtime/vm/cpuinfo_linux.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/os_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/unit_test.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/build.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/gyp/configurations.gypi	View		4 chunks	+46 lines, -2 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	tools/utils.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/303443010/diff/20001/runtime/vm/cpuinfo_linux.cc File runtime/vm/cpuinfo_linux.cc (right): https://codereview.chromium.org/303443010/diff/20001/runtime/vm/cpuinfo_linux.cc#newcode45 runtime/vm/cpuinfo_linux.cc:45: #elif defined(HOST_ARCH_ARM64) You could factor this section with ...

6 years, 7 months ago (2014-05-27 17:59:57 UTC) #2

zra

https://codereview.chromium.org/303443010/diff/20001/runtime/vm/cpuinfo_linux.cc File runtime/vm/cpuinfo_linux.cc (right): https://codereview.chromium.org/303443010/diff/20001/runtime/vm/cpuinfo_linux.cc#newcode45 runtime/vm/cpuinfo_linux.cc:45: #elif defined(HOST_ARCH_ARM64) On 2014/05/27 17:59:57, regis wrote: > You ...

6 years, 7 months ago (2014-05-27 18:04:59 UTC) #3

zra

6 years, 7 months ago (2014-05-27 18:05:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36698 (presubmit successful).

Expand Messages | Collapse Messages