Issue 303413003: Don't add files inside "packages" subdir to context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303413003: Don't add files inside "packages" subdir to context. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't add files inside "packages" subdir to context. In the short term this will allow us to make fair comparisons between the Java-based and Dart-based analysis engines. In the long run we'll be adding these files to the context using a separate mechanism (by finding them via "pub list-package-dirs"). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=36832

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	pkg/analysis_server/lib/src/context_directory_manager.dart	View	3 chunks	+25 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/resource.dart	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/context_directory_manager_test.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 6 months ago (2014-05-30 19:38:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36832 (presubmit successful).

Expand Messages | Collapse Messages