First cut at server timing tests

First cut at server timing tests

R=jwren@google.com, paulberry@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36874

[Paul Berry, 2014-05-30 15:47:20]

lgtm

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInContext.java
(right):

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInContext.java:147:
if (!name.equals("packages")) {
As currently implemented, the analysis server will add the contents of the
packages folder.  I'm hoping to change that soon, but even after I've changed
it, the contents of packages will still be added to the context--they will just
be added via the paths returned by "pub list-package-dirs".  So I think for a
fair timing comparison we need to go ahead and recurse into the packages
directory.

[scheglov, 2014-05-30 16:01:53]

lgtm

[jwren, 2014-05-30 16:04:34]

LGTM

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java
(right):

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java:120:
((RemoteAnalysisServerImpl) server).test_waitForWorkerComplete();
Will this will wait until the server has responded to the setAnalysisRoots, does
that imply that the analysis for the files is done?

[Brian Wilkerson, 2014-05-30 16:52:52]

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInContext.java
(right):

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInContext.java:147:
if (!name.equals("packages")) {
As far as I can see, Editor is not currently adding any files in packages to the
context, which is why I did it this way.

But this raises some interesting questions. The analysis engine will analyze any
referenced libraries, but won't analyze anything that is not reachable from an
added file, and if it isn't analyzed it can't be indexed.

I think I'll leave it as is until we've sorted out this issue.

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java
(right):

https://codereview.chromium.org/303233007/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java:120:
((RemoteAnalysisServerImpl) server).test_waitForWorkerComplete();
> Will this will wait until the server has responded to the setAnalysisRoots,

Looking at the code, that would be my guess.

> does that imply that the analysis for the files is done?

It looks like that isn't the case. I think what I'm going to have to do is
listen for errors until I've received notification for all of the files in the
directory tree. And that would explain the timing discrepency.

[Brian Wilkerson, 2014-05-31 18:24:21]

PTAL

[scheglov, 2014-06-02 14:29:40]

LGTM

[Brian Wilkerson, 2014-06-02 14:39:44]

Committed patchset #2 manually as r36874 (presubmit successful).