Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 303123004: Move PhysicalResourceProvider tests out of test_all.dart. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move PhysicalResourceProvider tests out of test_all.dart. These tests are slow since they require long delays to let the file system sync up. With this change, the tests will still run on the buildbots, but won't run on local developer machines unless the developer specifically chooses to execute physical_resource_provider_test.dart. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -201 lines) Patch
A pkg/analysis_server/test/physical_resource_provider_test.dart View 1 chunk +226 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/resource_test.dart View 1 chunk +0 lines, -201 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 6 months ago (2014-05-29 22:16:11 UTC) #1
scheglov
LGTM Thanks!
6 years, 6 months ago (2014-05-29 22:20:38 UTC) #2
Paul Berry
6 years, 6 months ago (2014-05-29 22:24:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698