Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 303113005: Convert analysis_server_test to use a helper class. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert analysis_server_test to use a helper class. Also remove some commented-out tests that are no longer relevant. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -198 lines) Patch
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +107 lines, -198 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 6 months ago (2014-05-30 20:12:17 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-05-30 20:55:57 UTC) #2
scheglov
LGTM
6 years, 6 months ago (2014-05-30 21:05:57 UTC) #3
Paul Berry
6 years, 6 months ago (2014-05-30 21:17:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698