Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 30283002: Adding validation that Custom element constructor has zero args (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding validation that Custom element constructor has zero args BUG=13800 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M tests/html/custom/created_callback_test.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 2 months ago (2013-10-19 00:23:12 UTC) #1
blois
On 2013/10/19 00:23:12, blois wrote: ping!
7 years, 2 months ago (2013-10-21 23:43:44 UTC) #2
vsm
lgtm
7 years, 2 months ago (2013-10-21 23:49:06 UTC) #3
blois
7 years, 2 months ago (2013-10-22 17:20:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698