Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 302813002: Attempted fix for Firefox flakiness. (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 7 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vsm, Emily Fortuna
Visibility:
Public.

Description

Attempted fix for Firefox flakiness. BUG=http://dartbug.com/19042 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36733

Patch Set 1 #

Patch Set 2 : Make sure onError is called. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M dart/tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/html/worker_test.dart View 1 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
6 years, 7 months ago (2014-05-28 08:46:49 UTC) #1
ahe
PTAL
6 years, 7 months ago (2014-05-28 08:58:15 UTC) #2
ricow1
lgtm
6 years, 7 months ago (2014-05-28 09:03:12 UTC) #3
ahe
6 years, 7 months ago (2014-05-28 09:05:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36733 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698