Issue 302753005: 1985 no longer supports webkitBackingStorePixelRatio on CanvasRenderingContext2D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302753005: 1985 no longer supports webkitBackingStorePixelRatio on CanvasRenderingContext2D (Closed)

Created:
6 years, 6 months ago by terry

Modified:
6 years, 6 months ago

Reviewers:
vsm, Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Supress webkitBackingStorePixelRatio and expose custom backingStorePixelRatio getter that always returns 1.0 Review=jacobr@google.com BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=36720

Patch Set 2 : Added @deprecated #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -39 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+5 lines, -17 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+5 lines, -16 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

add the @deprecated annotation then lgtm https://chromiumcodereview.appspot.com/302753005/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://chromiumcodereview.appspot.com/302753005/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode2047 sdk/lib/html/dart2js/html_dart2js.dart:2047: + @Experimental() use ...

6 years, 6 months ago (2014-05-27 23:21:40 UTC) #2

terry

Committed patchset #2 manually as r36720 (presubmit successful).

6 years, 6 months ago (2014-05-27 23:38:15 UTC) #3

terry

6 years, 6 months ago (2014-05-27 23:39:44 UTC) #4

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/302753005/diff/1/sdk/lib/html/dart2js/...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://chromiumcodereview.appspot.com/302753005/diff/1/sdk/lib/html/dart2js/...
sdk/lib/html/dart2js/html_dart2js.dart:2047: +  @Experimental()
On 2014/05/27 23:21:41, Jacob wrote:
> use the @deprecated annotation.

Done.

Expand Messages | Collapse Messages

Issue 302753005: 1985 no longer supports webkitBackingStorePixelRatio on CanvasRenderingContext2D (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added @deprecated #

Messages