Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 302703005: - Add isolate to ZoneHandle allocation in parser. (Closed)

Created:
6 years, 7 months ago by Ivan Posva
Modified:
6 years, 7 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Add isolate to ZoneHandle allocation in parser. - Add I macro which gets the local isolate(). R=johnmccutchan@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -228 lines) Patch
M runtime/vm/globals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 159 chunks +239 lines, -228 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
6 years, 7 months ago (2014-05-27 14:13:47 UTC) #1
srdjan
lgtm
6 years, 7 months ago (2014-05-27 14:22:33 UTC) #2
Cutch
lgtm
6 years, 7 months ago (2014-05-27 14:23:04 UTC) #3
Ivan Posva
6 years, 7 months ago (2014-05-27 14:30:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698