Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302503002: API and stubs for the 'analysis' domain. (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

API and stubs for the 'analysis' domain. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36611

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +16 lines, -0 lines 2 comments Download
A pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +231 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +118 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 7 months ago (2014-05-24 20:52:46 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/302503002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/302503002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode254 pkg/analysis_server/lib/src/analysis_server.dart:254: class AnalysisService extends Enum2<ServerService> { "ServerService" --> "AnalysisService" ...
6 years, 7 months ago (2014-05-25 14:51:32 UTC) #2
scheglov
Committed patchset #1 manually as r36611 (presubmit successful).
6 years, 7 months ago (2014-05-25 15:22:45 UTC) #3
scheglov
https://codereview.chromium.org/302503002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/302503002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode254 pkg/analysis_server/lib/src/analysis_server.dart:254: class AnalysisService extends Enum2<ServerService> { On 2014/05/25 14:51:32, Brian ...
6 years, 7 months ago (2014-05-25 15:23:17 UTC) #4
Paul Berry
6 years, 7 months ago (2014-05-27 15:47:32 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698