Issue 302323002: Add a boolean which causes AnalysisServer to rethrow exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302323002: Add a boolean which causes AnalysisServer to rethrow exceptions. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a boolean which causes AnalysisServer to rethrow exceptions. The boolean defaults to true to ensure that any unhandled analysis exceptions which occur during unit tests are reported as unit test failures. When the full analysis server is run normally it is set to false so that exceptions are simply logged. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36895

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -47 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	4 chunks	+22 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/socket_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_server_test.dart	View	3 chunks	+18 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	2 chunks	+0 lines, -36 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 6 months ago (2014-06-02 19:57:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36895 (presubmit successful).

Expand Messages | Collapse Messages