Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 302173007: Add HttpServerConnection to Observatory. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen
Modified:
6 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add HttpServerConnection to Observatory. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37166

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -71 lines) Patch
M runtime/bin/service_object_patch.dart View 1 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.html View 1 2 chunks +58 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 6 chunks +49 lines, -4 lines 0 comments Download
D tests/standalone/io/observatory.dart View 1 1 chunk +0 lines, -63 lines 0 comments Download
A + tests/standalone/io/observatory_test.dart View 1 2 chunks +38 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 6 months ago (2014-06-02 11:52:26 UTC) #1
Cutch
lgtm after adding tests.
6 years, 6 months ago (2014-06-09 15:07:04 UTC) #2
Anders Johnsen
6 years, 6 months ago (2014-06-10 07:33:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698