Issue 302143004: - Add Dart_EmptyString to return the canonical empty string similar to how

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302143004: - Add Dart_EmptyString to return the canonical empty string similar to how (Closed)

Created:
6 years, 6 months ago by siva

Modified:
6 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Add Dart_EmptyString to return the canonical empty string similar to how Null, True and False are done - Removed check for current isolate from Dart_Null, Dart_True, Dart_False, Dart_EmptyString as these are returning singleton objects. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36823

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -27 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	2 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	5 chunks	+13 lines, -21 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

6 years, 6 months ago (2014-05-30 17:33:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36823 (presubmit successful).

Expand Messages | Collapse Messages