Issue 302093013: pkg/matcher: small nits from previous CL

Issue 302093013: pkg/matcher: small nits from previous CL (Closed)

Created:
6 years, 6 months ago by kevmoo

Modified:
6 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/matcher: small nits from previous CL R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=36896

Patch Set 2 : cl nits #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
M	pkg/matcher/CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/matcher/README.md	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/matcher/lib/src/core_matchers.dart	View		4 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/matcher/lib/src/error_matchers.dart	View		13 chunks	+14 lines, -13 lines	0 comments	Download
M	pkg/matcher/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/302093013/diff/1/pkg/matcher/CHANGELOG.md File pkg/matcher/CHANGELOG.md (right): https://codereview.chromium.org/302093013/diff/1/pkg/matcher/CHANGELOG.md#newcode3 pkg/matcher/CHANGELOG.md:3: * Added return types to a number of ...

6 years, 6 months ago (2014-06-02 18:41:50 UTC) #2

kevmoo

Committed patchset #2 manually as r36896 (presubmit successful).

6 years, 6 months ago (2014-06-02 20:21:26 UTC) #3

kevmoo

6 years, 6 months ago (2014-06-02 20:28:49 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/302093013/diff/1/pkg/matcher/CHANGELOG.md
File pkg/matcher/CHANGELOG.md (right):

https://codereview.chromium.org/302093013/diff/1/pkg/matcher/CHANGELOG.md#new...
pkg/matcher/CHANGELOG.md:3: * Added return types to a number of constants.
On 2014/06/02 18:41:51, Siggi Cherem (dart-lang) wrote:
> remove "return" (unless they are functions?)

Done.

https://codereview.chromium.org/302093013/diff/1/pkg/matcher/CHANGELOG.md#new...
pkg/matcher/CHANGELOG.md:5: * Fixed link in `README.md`.
On 2014/06/02 18:41:51, Siggi Cherem (dart-lang) wrote:
> I don't think we need to mention this :) I think it's nice to keep the
changelog
> as a summary of how changes in the package affect users (new features, bug
> fixes, breaking changes), more details can always be found in the git logs.

Done.

Expand Messages | Collapse Messages