Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 30183005: port polymer - 00e2982c78fcd396adaebff3118e94029a2b9fb0 (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

port polymer - 00e2982c78fcd396adaebff3118e94029a2b9fb0 we're still missing a few commits (such as https://github.com/Polymer/polymer/pull/328) but this gets us pretty close to fixing https://code.google.com/p/dart/issues/detail?id=14377 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29192

Patch Set 1 #

Patch Set 2 : passing tests #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -159 lines) Patch
M pkg/polymer/lib/deserialize.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/lib/src/boot.dart View 1 chunk +27 lines, -5 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 14 chunks +30 lines, -49 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 2 17 chunks +264 lines, -89 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/polymer/test/publish_attributes_test.dart View 1 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 1 month ago (2013-10-24 02:56:41 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 1 month ago (2013-10-24 18:06:12 UTC) #2
Jennifer Messerly
7 years, 1 month ago (2013-10-24 18:45:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r29192 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698