Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 301683002: Send data with 404 response (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 7 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, Bill Hesse, kustermann
Visibility:
Public.

Description

Send data with 404 response The primary reason is to work around http://dartbug.com/19024, but this is not a hack or temporary code. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36675

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Rico's comments. #

Patch Set 3 : Merged with r36673 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M dart/tests/isolate/isolate.status View 2 chunks +0 lines, -5 lines 0 comments Download
M dart/tools/testing/dart/http_server.dart View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
6 years, 7 months ago (2014-05-27 11:22:51 UTC) #1
ricow1
lgtm https://codereview.chromium.org/301683002/diff/1/dart/tools/testing/dart/http_server.dart File dart/tools/testing/dart/http_server.dart (right): https://codereview.chromium.org/301683002/diff/1/dart/tools/testing/dart/http_server.dart#newcode386 dart/tools/testing/dart/http_server.dart:386: response.headers.set(HttpHeaders.CONTENT_TYPE, 'text/html'); could you add a small comment ...
6 years, 7 months ago (2014-05-27 12:42:49 UTC) #2
ahe
Thank you, Rico! https://codereview.chromium.org/301683002/diff/1/dart/tools/testing/dart/http_server.dart File dart/tools/testing/dart/http_server.dart (right): https://codereview.chromium.org/301683002/diff/1/dart/tools/testing/dart/http_server.dart#newcode386 dart/tools/testing/dart/http_server.dart:386: response.headers.set(HttpHeaders.CONTENT_TYPE, 'text/html'); On 2014/05/27 12:42:49, ricow1 ...
6 years, 7 months ago (2014-05-27 13:29:53 UTC) #3
ahe
6 years, 7 months ago (2014-05-27 13:30:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r36675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698