Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 301243003: Tweak dart2js typed_data for a little more shared code. (Closed)

Created:
6 years, 6 months ago by sra1
Modified:
6 years, 6 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, Cutch
Visibility:
Public.

Description

Tweak dart2js typed_data for a little more shared code. BUG= R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=37155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -75 lines) Patch
M sdk/lib/typed_data/dart2js/native_typed_data_dart2js.dart View 17 chunks +33 lines, -75 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 6 months ago (2014-05-30 02:26:59 UTC) #1
herhut
On 2014/05/30 02:26:59, sra1 wrote: LGTM. Just as a comment: It would be nice if ...
6 years, 6 months ago (2014-06-02 12:02:07 UTC) #2
sra1
6 years, 6 months ago (2014-06-10 04:24:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698