Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 30123002: Clarify that when a local variable hides a type before it is declared, it is stilla compile-time er… (Closed)

Created:
7 years, 2 months ago by gbracha
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clarify that when a local variable hides a type before it is declared, it is stilla compile-time error, and that the VM has flexibility to report such errors at the declaration rather than the use. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=28896

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M docs/language/dartLangSpec.tex View 1 4 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gbracha
7 years, 2 months ago (2013-10-18 22:46:19 UTC) #1
hausner
LGTM. https://codereview.chromium.org/30123002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/30123002/diff/1/docs/language/dartLangSpec.tex#newcode821 docs/language/dartLangSpec.tex:821: We allow the error to be reported at ...
7 years, 2 months ago (2013-10-18 23:09:23 UTC) #2
gbracha
7 years, 2 months ago (2013-10-18 23:12:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698