Issue 300883002: Add Proces owner of socket and fix printing of non-network sockets

Issue 300883002: Add Proces owner of socket and fix printing of non-network sockets (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Proces owner of socket and fix printing of non-network sockets R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=36729

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -12 lines)			Patch
M	runtime/bin/process_patch.dart	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/bin/service_object_patch.dart	View	1 2	3 chunks	+23 lines, -4 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1 2	4 chunks	+44 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/HACKING.txt	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3	2 chunks	+27 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2 3	2 chunks	+27 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html	View	1 2 3	2 chunks	+27 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/eval_box.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.html	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/300883002/diff/1/runtime/bin/vmservice/client/lib/src/elements/eval_box.dart File runtime/bin/vmservice/client/lib/src/elements/eval_box.dart (right): https://codereview.chromium.org/300883002/diff/1/runtime/bin/vmservice/client/lib/src/elements/eval_box.dart#newcode13 runtime/bin/vmservice/client/lib/src/elements/eval_box.dart:13: typedef Future evalType(String text); unrelated bug fix

6 years, 6 months ago (2014-05-28 06:34:01 UTC) #1

Anders Johnsen

LGTM! https://codereview.chromium.org/300883002/diff/20001/runtime/bin/service_object_patch.dart File runtime/bin/service_object_patch.dart (right): https://codereview.chromium.org/300883002/diff/20001/runtime/bin/service_object_patch.dart#newcode32 runtime/bin/service_object_patch.dart:32: return JSON.encode(_makeServiceError('Unrecognized path')); I think we should add ...

6 years, 6 months ago (2014-05-28 06:53:31 UTC) #2

Cutch

https://codereview.chromium.org/300883002/diff/20001/runtime/bin/service_object_patch.dart File runtime/bin/service_object_patch.dart (right): https://codereview.chromium.org/300883002/diff/20001/runtime/bin/service_object_patch.dart#newcode32 runtime/bin/service_object_patch.dart:32: return JSON.encode(_makeServiceError('Unrecognized path')); On 2014/05/28 06:53:32, Anders Johnsen wrote: ...

6 years, 6 months ago (2014-05-28 07:07:40 UTC) #3

Cutch

6 years, 6 months ago (2014-05-28 07:15:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r36729 (presubmit successful).

Expand Messages | Collapse Messages