Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 300763002: Don't require eliminating certain type checks in unoptimized compilation. (Closed)

Created:
6 years, 7 months ago by Florian Schneider
Modified:
6 years, 6 months ago
Reviewers:
regis, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Visibility:
Public.

Description

Don't require eliminating certain type checks in unoptimized compilation. The compiler relied on the graph builder to eliminate certain type checks so that running without type check elimination required a hack in the code generator to deal with the transition sentinel. This CL makes type checks explicit in the AST and avoid inserting them where they're not necessary (e.g. assigning null, sentinal values). R=regis@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36734

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -52 lines) Patch
M runtime/vm/ast.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
6 years, 7 months ago (2014-05-27 11:59:18 UTC) #1
srdjan
lgtm
6 years, 7 months ago (2014-05-27 12:50:08 UTC) #2
regis
LGTM
6 years, 7 months ago (2014-05-27 16:17:54 UTC) #3
Florian Schneider
6 years, 6 months ago (2014-05-28 10:16:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698