Use type annotations everywhere in analysis_server/lib.

Use type annotations everywhere in analysis_server/lib.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36610

[Brian Wilkerson, 2014-05-24 17:36:52]

LGTM, but I'd probably revert protocol.dart if it were me.

https://codereview.chromium.org/300643002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/300643002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:72: dynamic result =
DECODER.convert(data);
Hm. It might be better to leave 'var' in places where we don't *have* type
information (which is everywhere it previously was in this file) as a marker
that we're using an untyped API. Not sure about that...

[scheglov, 2014-05-24 17:45:49]

https://codereview.chromium.org/300643002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/300643002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:72: dynamic result =
DECODER.convert(data);
On 2014/05/24 17:36:52, Brian Wilkerson wrote:
> Hm. It might be better to leave 'var' in places where we don't *have* type
> information (which is everywhere it previously was in this file) as a marker
> that we're using an untyped API. Not sure about that...

I rolled back places where we use "dynamic" type.

[scheglov, 2014-05-24 17:46:33]

Committed patchset #2 manually as r36610 (presubmit successful).

[Paul Berry, 2014-05-27 15:43:46]

lgtm