Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 300583002: Make source map location information more readable. (Closed)

Created:
6 years, 7 months ago by nweiz
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make source map location information more readable. This changes "file:1:2" to "line 1, column 2 of file" and ":1:2" to "line 1, column 2" in [SourceFile.getLocationMessage]. The more machine-readable colon-separated format doesn't make sense for a message intended for humans. Since [Location.formatString] seems more likely to be consumed by machines, its format was left as-is. This also prepares version 0.9.1 for release. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=36603

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
A pkg/source_maps/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/source_maps/lib/span.dart View 2 chunks +4 lines, -2 lines 2 comments Download
M pkg/source_maps/pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/source_maps/test/span_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 7 months ago (2014-05-24 00:26:23 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/300583002/diff/1/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/300583002/diff/1/pkg/source_maps/lib/span.dart#newcode257 pkg/source_maps/lib/span.dart:257: var source = url == null ? '' ...
6 years, 7 months ago (2014-05-24 00:37:03 UTC) #2
nweiz
https://codereview.chromium.org/300583002/diff/1/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/300583002/diff/1/pkg/source_maps/lib/span.dart#newcode257 pkg/source_maps/lib/span.dart:257: var source = url == null ? '' : ...
6 years, 7 months ago (2014-05-24 00:51:27 UTC) #3
nweiz
6 years, 7 months ago (2014-05-24 00:52:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698