Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 300553014: Implementation for 'analysis.updateContent' API. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementation for 'analysis.updateContent' API. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36766

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -22 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +33 lines, -5 lines 2 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 4 chunks +40 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 4 chunks +82 lines, -15 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-05-28 20:30:41 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/300553014/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/300553014/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode341 pkg/analysis_server/lib/src/analysis_server.dart:341: print('setContents: $file'); Remove debugging output? https://codereview.chromium.org/300553014/diff/1/pkg/analysis_server/test/domain_analysis_test.dart File pkg/analysis_server/test/domain_analysis_test.dart ...
6 years, 6 months ago (2014-05-28 20:38:15 UTC) #2
scheglov
https://codereview.chromium.org/300553014/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/300553014/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode341 pkg/analysis_server/lib/src/analysis_server.dart:341: print('setContents: $file'); On 2014/05/28 20:38:15, Brian Wilkerson wrote: > ...
6 years, 6 months ago (2014-05-28 20:44:05 UTC) #3
scheglov
6 years, 6 months ago (2014-05-28 20:44:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698