Revert "Revert "Resolve metadata on library tags""

Revert "Revert "Resolve metadata on library tags""

Original CL (https://codereview.chromium.org/29263006/) was reverted and re-applied here with an additional null check

Committed: https://code.google.com/p/dart/source/detail?r=28887

[sra1, 2013-10-18 22:10:07]

Committed patchset #1 manually as r28887 (presubmit successful).

[sra1, 2013-10-18 23:26:47]

TBR=kasperl

This should unblock the release work.

[kasperl, 2013-10-19 11:52:25]

LGTM. Thanks, Stephen!

[kasperl, 2013-10-19 12:02:26]

One meta comment: I think you should make a habit of changing the CL description
when you revert reverts. Personally I much prefer something ala

   Re-land "Resolve metadata on library tags"

over

  Revert "Revert "Resolve metadata on library tags""

[ahe, 2013-10-22 10:51:10]

Help me understand the purpose of this: do you have a bug report or a
description of what problem you solved?

I see the regression tests, and I see I have gotten a new todo. But I'm still
not sure I understand the context.

[sra1, 2013-10-22 17:39:50]

On 2013/10/22 10:51:10, ahe wrote:
> Help me understand the purpose of this: do you have a bug report or a
> description of what problem you solved?
> 
> I see the regression tests, and I see I have gotten a new todo. But I'm still
> not sure I understand the context.

You ususally have ideas about how this kind of thing could be done better, but
you were out sick.
If you think this solution is OK, I'll remove the TODO.

I'm not sure there is anything more to say about the context - without the fix,
dart2js attempts to scan unresolved metadata and crashes, and the crash was
blocking milestone integration.

I added the TODO only because one was added for you to the previous issue that
was blocking integration:
https://codereview.chromium.org/26800008/diff/65001/sdk/lib/_internal/compile...

[ahe, 2013-10-22 18:04:34]

On 2013/10/22 17:39:50, sra1 wrote:
> On 2013/10/22 10:51:10, ahe wrote:
> > Help me understand the purpose of this: do you have a bug report or a
> > description of what problem you solved?
> > 
> > I see the regression tests, and I see I have gotten a new todo. But I'm
still
> > not sure I understand the context.
> 
> You ususally have ideas about how this kind of thing could be done better, but
> you were out sick.
> If you think this solution is OK, I'll remove the TODO.
> 
> I'm not sure there is anything more to say about the context - without the
fix,
> dart2js attempts to scan unresolved metadata and crashes, and the crash was
> blocking milestone integration.
> 
> I added the TODO only because one was added for you to the previous issue that
> was blocking integration:
>
https://codereview.chromium.org/26800008/diff/65001/sdk/lib/_internal/compile...

Thank you. I have filed: https://code.google.com/p/dart/issues/detail?id=14313