Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 300113005: Untype 'Socket' a few places, where we try to call a hidden function. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Untype 'Socket' a few places, where we try to call a hidden function. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-27 13:16:15 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-27 13:17:04 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-27 13:18:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698