Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 300043012: Communicate defined variables to the context (Closed)

Created:
6 years, 7 months ago by Brian Wilkerson
Modified:
6 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Communicate defined variables to the context. With this change we ought to be able to get defined variables from the command-line to the context and should be unblocked for using the values in constant evaluation. R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=36695

Patch Set 1 #

Patch Set 2 : Add missed type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
6 years, 7 months ago (2014-05-27 16:37:02 UTC) #1
Paul Berry
lgtm
6 years, 7 months ago (2014-05-27 16:40:16 UTC) #2
Brian Wilkerson
6 years, 7 months ago (2014-05-27 16:46:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698