Issue 300043011: Add WebSockets to Observatory.

Issue 300043011: Add WebSockets to Observatory. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 1 month ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add WebSockets to Observatory. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36667

Patch Set 2 : Deploy #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5311 lines, -2891 lines)			Patch
M	runtime/bin/service_object_patch.dart	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1	3 chunks	+761 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1	363 chunks	+1775 lines, -1438 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1	3 chunks	+761 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1	363 chunks	+1775 lines, -1438 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html	View	1	3 chunks	+71 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.dart	View	1	2 chunks	+28 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.html	View	1	3 chunks	+71 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/service_view.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1	4 chunks	+35 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm https://codereview.chromium.org/300043011/diff/1/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/300043011/diff/1/sdk/lib/io/websocket_impl.dart#newcode983 sdk/lib/io/websocket_impl.dart:983: 'name': '${_socket.address.host}:${_socket.port}', Should the string interpolation be done ...

6 years, 6 months ago (2014-05-27 11:04:53 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r36667 (presubmit successful).

6 years, 6 months ago (2014-05-27 11:38:04 UTC) #3

Anders Johnsen

6 years, 1 month ago (2014-11-13 16:20:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/300043011/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/300043011/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:983: 'name':
'${_socket.address.host}:${_socket.port}',
On 2014/05/27 11:04:53, Cutch wrote:
> Should the string interpolation be done once ?

Done.

Expand Messages | Collapse Messages