Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 300043009: Use Posix style for memory resources. (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove casting 'posix' to Context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/resource.dart View 1 7 chunks +13 lines, -13 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 7 months ago (2014-05-26 19:45:50 UTC) #1
karlklose
https://codereview.chromium.org/300043009/diff/1/pkg/analysis_server/lib/src/resource.dart File pkg/analysis_server/lib/src/resource.dart (right): https://codereview.chromium.org/300043009/diff/1/pkg/analysis_server/lib/src/resource.dart#newcode103 pkg/analysis_server/lib/src/resource.dart:103: String get shortName => (posix as Context).basename(_path); Consider adding ...
6 years, 7 months ago (2014-05-27 07:57:20 UTC) #2
scheglov
On 2014/05/27 07:57:20, karlklose wrote: > https://codereview.chromium.org/300043009/diff/1/pkg/analysis_server/lib/src/resource.dart > File pkg/analysis_server/lib/src/resource.dart (right): > > https://codereview.chromium.org/300043009/diff/1/pkg/analysis_server/lib/src/resource.dart#newcode103 > ...
6 years, 7 months ago (2014-05-27 17:32:02 UTC) #3
Brian Wilkerson
LGTM
6 years, 7 months ago (2014-05-27 17:38:26 UTC) #4
scheglov
6 years, 7 months ago (2014-05-27 18:25:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698