Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 299623003: Revert "Make Stream.where, etc., be documented as inheriting broadcast state." (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Make Stream.where, etc., be documented as inheriting broadcast state." There were ... complications. Committed: https://code.google.com/p/dart/source/detail?r=36347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -233 lines) Patch
M sdk/lib/async/stream.dart View 15 chunks +54 lines, -69 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/lib/async/stream_timeout_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D tests/lib/async/stream_transformation_broadcast_test.dart View 1 chunk +0 lines, -160 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
6 years, 7 months ago (2014-05-20 08:30:18 UTC) #1
Anders Johnsen
lgtm
6 years, 7 months ago (2014-05-20 08:30:39 UTC) #2
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-20 08:30:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698