Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993483002: Update comment style generic syntax (Closed)

Created:
3 years, 4 months ago by keertip
Modified:
3 years, 4 months ago
Reviewers:
Nate Bosch, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : format file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M lib/src/scan.dart View 1 2 chunks +9 lines, -2 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
keertip
3 years, 4 months ago (2017-07-31 16:54:06 UTC) #2
Nate Bosch
lgtm https://codereview.chromium.org/2993483002/diff/1/lib/src/scan.dart File lib/src/scan.dart (right): https://codereview.chromium.org/2993483002/diff/1/lib/src/scan.dart#newcode41 lib/src/scan.dart:41: var result = <T> []; Have you run ...
3 years, 4 months ago (2017-07-31 17:06:52 UTC) #3
keertip
https://codereview.chromium.org/2993483002/diff/1/lib/src/scan.dart File lib/src/scan.dart (right): https://codereview.chromium.org/2993483002/diff/1/lib/src/scan.dart#newcode41 lib/src/scan.dart:41: var result = <T> []; On 2017/07/31 17:06:52, Nate ...
3 years, 4 months ago (2017-07-31 17:33:27 UTC) #4
keertip
3 years, 4 months ago (2017-07-31 17:34:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e562446dbd552734239e6f51e4d5859b6f24a46e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698