Issue 2987963002: Update comment style generic syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2987963002: Update comment style generic syntax (Closed)

Created:
3 years, 4 months ago by keertip

Modified:
3 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update comment style generic syntax BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/stream_channel/commit/67b588d868d4d1ef1d054d8e22fef1453446561f

Patch Set 1 #

Total comments: 1

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	lib/src/stream_channel_transformer.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/stream_channel.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

lgtm https://codereview.chromium.org/2987963002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2987963002/diff/1/pubspec.yaml#newcode7 pubspec.yaml:7: sdk: '>=1.21.0 <2.0.0-dev.infinity' Thanks!

3 years, 4 months ago (2017-07-26 21:33:21 UTC) #3

keertip

3 years, 4 months ago (2017-07-26 21:54:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
67b588d868d4d1ef1d054d8e22fef1453446561f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages