Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 298683003: Use shelf in pub's barback and admin servers. (Closed)

Created:
6 years, 7 months ago by nweiz
Modified:
6 years, 7 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Visibility:
Public.

Description

Use shelf in pub's barback and admin servers. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=36706

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -99 lines) Patch
M sdk/lib/_internal/pub/asset/dart/serialize/transformer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/admin_server.dart View 4 chunks +22 lines, -23 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/barback_server.dart View 1 4 chunks +24 lines, -42 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/base_server.dart View 5 chunks +32 lines, -29 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lish/utils.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/utils.dart View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 7 months ago (2014-05-21 20:25:07 UTC) #1
kevmoo
DBC You can remove some unused imports in test files: test/lish/utils.dart: remove dart:io test/oauth2/utils.dart: remove ...
6 years, 7 months ago (2014-05-21 21:11:24 UTC) #2
Bob Nystrom
LGTM! https://codereview.chromium.org/298683003/diff/1/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart File sdk/lib/_internal/pub/lib/src/barback/barback_server.dart (right): https://codereview.chromium.org/298683003/diff/1/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart#newcode93 sdk/lib/_internal/pub/lib/src/barback/barback_server.dart:93: // directory, but not a valid path since ...
6 years, 7 months ago (2014-05-27 17:25:50 UTC) #3
nweiz
https://codereview.chromium.org/298683003/diff/1/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart File sdk/lib/_internal/pub/lib/src/barback/barback_server.dart (right): https://codereview.chromium.org/298683003/diff/1/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart#newcode93 sdk/lib/_internal/pub/lib/src/barback/barback_server.dart:93: // directory, but not a valid path since it ...
6 years, 7 months ago (2014-05-27 20:25:33 UTC) #4
nweiz
6 years, 7 months ago (2014-05-27 20:26:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698