Issue 298533002: For arm, chooses hard vs. soft fp ABI based on compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298533002: For arm, chooses hard vs. soft fp ABI based on compiler. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

For arm, chooses hard vs. soft fp ABI based on compiler. We have been hard-coding hardfp in the gyp file. This makes using softfp hard. This change detects hardfp by looking at a predefined gcc macro, and otherwise uses softfp. This change also adds a flag to simarm so that we can test softfp. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36337

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -90 lines)			Patch
M	runtime/vm/cpu_arm.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/cpu_arm.cc	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	5 chunks	+50 lines, -50 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 chunk	+25 lines, -25 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	3 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

6 years, 7 months ago (2014-05-19 23:13:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36337 (presubmit successful).

Expand Messages | Collapse Messages